scsi: core: Move scsi_host_busy() out of host lock for waking up EH handler
Description
In the Linux kernel, the following vulnerability has been resolved:
scsi: core: Move scsi_host_busy() out of host lock for waking up EH handler
Inside scsi_eh_wakeup(), scsi_host_busy() is called & checked with host lock every time for deciding if error handler kthread needs to be waken up.
This can be too heavy in case of recovery, such as:
- N hardware queues
- queue depth is M for each hardware queue
- each scsi_host_busy() iterates over (N * M) tag/requests
If recovery is triggered in case that all requests are in-flight, each scsi_eh_wakeup() is strictly serialized, when scsi_eh_wakeup() is called for the last in-flight request, scsi_host_busy() has been run for (N * M - 1) times, and request has been iterated for (N*M - 1) * (N * M) times.
If both N and M are big enough, hard lockup can be triggered on acquiring host lock, and it is observed on mpi3mr(128 hw queues, queue depth 8169).
Fix the issue by calling scsi_host_busy() outside the host lock. We don't need the host lock for getting busy count because host the lock never covers that.
[mkp: Drop unnecessary 'busy' variables pointed out by Bart]
Affected products
50- osv-coords49 versionspkg:deb/ubuntu/linux-aws@6.5.0-1021.21?arch=source&distro=manticpkg:deb/ubuntu/linux-laptop@6.5.0-1017.20?arch=source&distro=manticpkg:deb/ubuntu/linux-oem-6.5pkg:deb/ubuntu/linux-oracle@6.5.0-1024.24?arch=source&distro=manticpkg:rpm/opensuse/dtb-aarch64&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-64kb&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-azure&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-debug&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-default-base&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-default&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-docs&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-kvmsmall&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-obs-build&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-obs-qa&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-rt_debug&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-rt&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-source-azure&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-source&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-source-rt&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-syms-azure&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-syms&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-syms-rt&distro=openSUSE%20Leap%2015.5pkg:rpm/opensuse/kernel-zfcpdump&distro=openSUSE%20Leap%2015.5pkg:rpm/suse/kernel-64kb&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Basesystem%2015%20SP5pkg:rpm/suse/kernel-azure&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Public%20Cloud%2015%20SP5pkg:rpm/suse/kernel-default-base&distro=SUSE%20Linux%20Enterprise%20Micro%205.5pkg:rpm/suse/kernel-default-base&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Basesystem%2015%20SP5pkg:rpm/suse/kernel-default&distro=SUSE%20Linux%20Enterprise%20High%20Availability%20Extension%2015%20SP5pkg:rpm/suse/kernel-default&distro=SUSE%20Linux%20Enterprise%20Live%20Patching%2015%20SP5pkg:rpm/suse/kernel-default&distro=SUSE%20Linux%20Enterprise%20Micro%205.5pkg:rpm/suse/kernel-default&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Basesystem%2015%20SP5pkg:rpm/suse/kernel-default&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Legacy%2015%20SP5pkg:rpm/suse/kernel-default&distro=SUSE%20Linux%20Enterprise%20Workstation%20Extension%2015%20SP5pkg:rpm/suse/kernel-docs&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Development%20Tools%2015%20SP5pkg:rpm/suse/kernel-livepatch-SLE15-SP5-RT_Update_13&distro=SUSE%20Linux%20Enterprise%20Live%20Patching%2015%20SP5pkg:rpm/suse/kernel-livepatch-SLE15-SP5_Update_12&distro=SUSE%20Linux%20Enterprise%20Live%20Patching%2015%20SP5pkg:rpm/suse/kernel-obs-build&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Development%20Tools%2015%20SP5pkg:rpm/suse/kernel-rt_debug&distro=SUSE%20Real%20Time%20Module%2015%20SP5pkg:rpm/suse/kernel-rt&distro=SUSE%20Linux%20Enterprise%20Micro%205.5pkg:rpm/suse/kernel-rt&distro=SUSE%20Real%20Time%20Module%2015%20SP5pkg:rpm/suse/kernel-source-azure&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Public%20Cloud%2015%20SP5pkg:rpm/suse/kernel-source&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Basesystem%2015%20SP5pkg:rpm/suse/kernel-source&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Development%20Tools%2015%20SP5pkg:rpm/suse/kernel-source-rt&distro=SUSE%20Linux%20Enterprise%20Micro%205.5pkg:rpm/suse/kernel-source-rt&distro=SUSE%20Real%20Time%20Module%2015%20SP5pkg:rpm/suse/kernel-syms-azure&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Public%20Cloud%2015%20SP5pkg:rpm/suse/kernel-syms&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Development%20Tools%2015%20SP5pkg:rpm/suse/kernel-syms-rt&distro=SUSE%20Real%20Time%20Module%2015%20SP5pkg:rpm/suse/kernel-zfcpdump&distro=SUSE%20Linux%20Enterprise%20Module%20for%20Basesystem%2015%20SP5
< 6.5.0-1021.21+ 48 more
- (no CPE)range: < 6.5.0-1021.21
- (no CPE)range: < 6.5.0-1017.20
- (no CPE)range: < 6.5.0-1022.23
- (no CPE)range: < 6.5.0-1024.24
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.33.48.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1.150500.6.25.7
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.33.48.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.33.48.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.33.48.1
- (no CPE)range: < 5.14.21-150500.55.59.1.150500.6.25.7
- (no CPE)range: < 5.14.21-150500.55.59.1.150500.6.25.7
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 1-150500.11.3.1
- (no CPE)range: < 1-150500.11.7.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.33.48.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.33.48.1
- (no CPE)range: < 5.14.21-150500.55.59.1
- (no CPE)range: < 5.14.21-150500.13.47.1
- (no CPE)range: < 5.14.21-150500.55.59.1
Patches
0No patches discovered yet.
Vulnerability mechanics
AI mechanics synthesis has not run for this CVE yet.
References
6- git.kernel.org/stable/c/07e3ca0f17f579491b5f54e9ed05173d6c1d6fcbmitre
- git.kernel.org/stable/c/4373534a9850627a2695317944898eb1283a2db0mitre
- git.kernel.org/stable/c/65ead8468c21c2676d4d06f50b46beffdea69df1mitre
- git.kernel.org/stable/c/d37c1c81419fdef66ebd0747cf76fb8b7d979059mitre
- git.kernel.org/stable/c/db6338f45971b4285ea368432a84033690eaf53cmitre
- git.kernel.org/stable/c/f5944853f7a961fedc1227dc8f60393f8936d37cmitre
News mentions
0No linked articles in our index yet.