node-tar: Hardlink Path Traversal via Drive-Relative Linkpath

@@ -8,7 +8,7 @@ const { isAbsolute, parse } = win32
 // explicitly if it's the first character.
 // drive-specific relative paths on Windows get their root stripped off even
 // though they are not absolute, so `c:../foo` becomes ['c:', '../foo']
-export const stripAbsolutePath = (path: string) => {
+export const stripAbsolutePath = (path: string): [string, string] => {
   let r = ''
 
   let parsed = parse(path)

@@ -277,7 +277,9 @@ export class Unpack extends Parser {
     const { type } = entry
     if (!p || this.preservePaths) return true
 
-    const parts = p.split('/')
+    // strip off the root
+    const [root, stripped] = stripAbsolutePath(p)
+    const parts = stripped.replace(/\\/g, '/').split('/')
 
     if (
       parts.includes('..') ||
@@ -318,8 +320,6 @@ export class Unpack extends Parser {
       }
     }
 
-    // strip off the root
-    const [root, stripped] = stripAbsolutePath(p)
     if (root) {
       // ok, but triggers warning about stripping root
       entry[field] = String(stripped)

@@ -70,6 +70,14 @@ const getExploitTar = () => {
   }).encode(absWithDotDotHeader, 0)
   chunks.push(absWithDotDotHeader)
 
+  const winAbsWithDotDotHeader = Buffer.alloc(512)
+  new Header({
+    path: 'a/winrootdotslink',
+    type: 'SymbolicLink',
+    linkpath: 'c:..\\foo\\bar',
+  }).encode(winAbsWithDotDotHeader, 0)
+  chunks.push(winAbsWithDotDotHeader)
+
   chunks.push(Buffer.alloc(1024))
   return Buffer.concat(chunks)
 }
@@ -83,9 +91,9 @@ const dir = t.testdir({
 const out = resolve(dir, 'out')
 const tarFile = resolve(dir, 'exploit.tar')
 
-t.test('hardlink escape does not clobber target', async t => {
-  await x({ cwd: out, file: tarFile })
+t.before(() => x({ cwd: out, file: tarFile }))
 
+t.test('writefile exploits fail', async t => {
   writeFileSync(resolve(out, 'exploit_hard'), 'OVERWRITTEN')
   t.equal(
     readFileSync(resolve(dir, 'secret.txt'), 'utf8'),
@@ -100,20 +108,22 @@ t.test('hardlink escape does not clobber target', async t => {
 })
 
 t.test('symlink escapes are sanitized', async t => {
-  await x({ cwd: out, file: tarFile })
-
   t.not(readlinkSync(resolve(out, 'exploit_sym')), targetSym)
   t.throws(() => lstatSync(resolve(out, 'secret.txt')), {
     code: 'ENOENT',
   })
 })
 
 t.test('absolute symlink with .. has prefix stripped', async t => {
-  await x({ cwd: out, file: tarFile })
-
   t.equal(
     readlinkSync(resolve(out, 'a/link')),
     '../a/target',
     'symlink target should be normalized',
   )
+
+  t.equal(
+    readlinkSync(resolve(out, 'a/winrootdotslink')),
+    '..\\foo\\bar',
+    'symlink target should be normalized',
+  )
 })