VYPR
Moderate severityNVD Advisory· Published Mar 16, 2026· Updated Mar 16, 2026

Denial of service via malformed User-Agent header in getBrowserVersion

CVE-2026-25783

Description

Mattermost versions 11.3.x <= 11.3.0, 11.2.x <= 11.2.2, 10.11.x <= 10.11.10 fail to properly validate User-Agent header tokens which allows an authenticated attacker to cause a request panic via a specially crafted User-Agent header. Mattermost Advisory ID: MMSA-2026-00586

Affected packages

Versions sourced from the GitHub Security Advisory.

PackageAffected versionsPatched versions
github.com/mattermost/mattermost/server/v8Go
< 8.0.0-20260129181235-1346cf529aef8.0.0-20260129181235-1346cf529aef
github.com/mattermost/mattermost-serverGo
< 5.3.2-0.20260129181235-1346cf529aef5.3.2-0.20260129181235-1346cf529aef
github.com/mattermost/mattermost-serverGo
>= 10.11.0-rc1, < 10.11.1110.11.11
github.com/mattermost/mattermost-serverGo
>= 11.2.0-rc1, < 11.2.311.2.3
github.com/mattermost/mattermost-serverGo
>= 11.3.0-rc1, < 11.3.111.3.1

Affected products

1

Patches

1
1346cf529aef

MM-67274: Fix panic in getBrowserVersion with empty User-Agent version (#35098)

https://github.com/mattermost/mattermostJesse HallamJan 29, 2026via ghsa
2 files changed · +290 194
  • server/channels/app/user_agent.go+15 20 modified
    @@ -107,28 +107,23 @@ func getOSName(ua *uasurfer.UserAgent, userAgentString string) string {
     	return osNames[uasurfer.OSUnknown]
     }
     
    -func getBrowserVersion(ua *uasurfer.UserAgent, userAgentString string) string {
    -	if index := strings.Index(userAgentString, "Mattermost Mobile/"); index != -1 {
    -		afterVersion := userAgentString[index+len("Mattermost Mobile/"):]
    -		// MM-55320: limitStringLength prevents potential DOS caused by filling an unbounded string with junk data
    -		return limitStringLength(strings.Fields(afterVersion)[0], maxUserAgentVersionLength)
    -	}
    -
    -	if index := strings.Index(userAgentString, "Mattermost/"); index != -1 {
    -		afterVersion := userAgentString[index+len("Mattermost/"):]
    -		return limitStringLength(strings.Fields(afterVersion)[0], maxUserAgentVersionLength)
    -	}
    -
    -	if index := strings.Index(userAgentString, "mmctl/"); index != -1 {
    -		afterVersion := userAgentString[index+len("mmctl/"):]
    -		return limitStringLength(strings.Fields(afterVersion)[0], maxUserAgentVersionLength)
    -	}
    +var versionPrefixes = []string{
    +	"Mattermost Mobile/",
    +	"Mattermost/",
    +	"mmctl/",
    +	"Franz/",
    +}
     
    -	if index := strings.Index(userAgentString, "Franz/"); index != -1 {
    -		afterVersion := userAgentString[index+len("Franz/"):]
    -		return limitStringLength(strings.Fields(afterVersion)[0], maxUserAgentVersionLength)
    +func getBrowserVersion(ua *uasurfer.UserAgent, userAgentString string) string {
    +	for _, prefix := range versionPrefixes {
    +		if index := strings.Index(userAgentString, prefix); index != -1 {
    +			afterPrefix := userAgentString[index+len(prefix):]
    +			if fields := strings.Fields(afterPrefix); len(fields) > 0 {
    +				// MM-55320: limitStringLength prevents potential DOS caused by filling an unbounded string with junk data
    +				return limitStringLength(fields[0], maxUserAgentVersionLength)
    +			}
    +		}
     	}
    -
     	return getUAVersion(ua.Browser.Version)
     }
     
    
  • server/channels/app/user_agent_test.go+275 174 modified
    @@ -4,212 +4,313 @@
     package app
     
     import (
    -	"fmt"
     	"testing"
     
     	"github.com/avct/uasurfer"
     	"github.com/stretchr/testify/assert"
     )
     
     type testUserAgent struct {
    -	Name      string
    -	UserAgent string
    +	Name                   string
    +	UserAgent              string
    +	ExpectedPlatformName   string
    +	ExpectedOSName         string
    +	ExpectedBrowserName    string
    +	ExpectedBrowserVersion string
     }
     
     var testUserAgents = []testUserAgent{
    -	{"Mozilla 40.1", "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1"},
    -	{"Chrome 60", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36"},
    -	{"Chrome Mobile", "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Mobile Safari/537.36"},
    -	{"MM Classic App", "Mozilla/5.0 (Linux; Android 8.0.0; Nexus 5X Build/OPR6.170623.013; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/61.0.3163.81 Mobile Safari/537.36 Web-Atoms-Mobile-WebView"},
    -	{"mmctl", "mmctl/5.20.0 (linux)"},
    -	{"MM App 3.7.1", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Mattermost/3.7.1 Chrome/56.0.2924.87 Electron/1.6.11 Safari/537.36"},
    -	{"Franz 4.0.4", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Franz/4.0.4 Chrome/52.0.2743.82 Electron/1.3.1 Safari/537.36"},
    -	{"Edge 14", "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393"},
    -	{"Internet Explorer 9", "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 7.1; Trident/5.0"},
    -	{"Internet Explorer 11", "Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko"},
    -	{"Internet Explorer 11 2", "Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Zoom 3.6.0; rv:11.0) like Gecko"},
    -	{"Internet Explorer 11 (Compatibility Mode) 1", "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; .NET CLR 1.1.4322; InfoPath.3; Zoom 3.6.0)"},
    -	{"Internet Explorer 11 (Compatibility Mode) 2", "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Zoom 3.6.0)"},
    -	{"Safari 9", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Safari/604.1.38"},
    -	{"Safari 8", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/600.7.12 (KHTML, like Gecko) Version/8.0.7 Safari/600.7.12"},
    -	{"Safari Mobile", "Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13B137 Safari/601.1"},
    -	{"Mobile App", "Mattermost Mobile/2.7.0+482 (Android; 13; sdk_gphone64_arm64)"},
    -	{"Mobile App", "Mattermost Mobile/233.234441.341234223421341234529099823109834440981234+abcdef3214eafeabc3242331129857301afesfffff1930a84e4bd2348fe129ac1309bd929dca3419af934bfe3089fcd (Android; 13; sdk_gphone64_arm64)"},
    -	{"Firefox (Mac)", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:132.0) Gecko/20100101 Firefox/132.0"},
    -	{"Desktop App (Mac)", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.127 Electron/31.2.1 Safari/537.36 Mattermost/5.9.0"},
    -	{"Mobile App (Android, Samsung Galaxy Fold Z)", "Mattermost Mobile/2.20.0+6000556 (samsung/q4qcsx/q4q:14/UP1A.231005.007/F936WVLU4FXE3:user/release-keys; 14; SM-F936W)"},
    -	{"Chrome (Android)", "Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Mobile Safari/537.36"},
    -	{"iOS App (iPhone 13)", "Mattermost Mobile/2.20.0+556 (iOS; 17.5.1; iPhone 13)"},
    -	{"Safari (iPhone 13)", "Mozilla/5.0 (iPhone; CPU iPhone OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Mobile/15E148 Safari/604.1"},
    -	{"iOS App (iPad 11 Pro)", "Mattermost Mobile/2.21.0+567 (iPadOS; 17.6.1; iPad Pro (11-inch) (1st generation))"},
    -	{"Safari (iPad 11 Pro, default)", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.6 Safari/605.1.15"},
    -	{"Safari (iPad 11 Pro, requesting mobile site)", "Mozilla/5.0 (iPad; CPU OS 17_6_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.6 Mobile/15E148 Safari/604.1"},
    +	{
    +		Name:                   "Mozilla 40.1",
    +		UserAgent:              "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows 7",
    +		ExpectedBrowserName:    "Firefox",
    +		ExpectedBrowserVersion: "40.1",
    +	},
    +	{
    +		Name:                   "Chrome 60",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Chrome",
    +		ExpectedBrowserVersion: "60.0.3112",
    +	},
    +	{
    +		Name:                   "Chrome Mobile",
    +		UserAgent:              "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Mobile Safari/537.36",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Chrome",
    +		ExpectedBrowserVersion: "60.0.3112",
    +	},
    +	{
    +		Name:                   "MM Classic App",
    +		UserAgent:              "Mozilla/5.0 (Linux; Android 8.0.0; Nexus 5X Build/OPR6.170623.013; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/61.0.3163.81 Mobile Safari/537.36 Web-Atoms-Mobile-WebView",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Chrome",
    +		ExpectedBrowserVersion: "61.0.3163",
    +	},
    +	{
    +		Name:                   "mmctl",
    +		UserAgent:              "mmctl/5.20.0 (linux)",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Linux",
    +		ExpectedBrowserName:    "mmctl",
    +		ExpectedBrowserVersion: "5.20.0",
    +	},
    +	{
    +		Name:                   "MM App 3.7.1",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Mattermost/3.7.1 Chrome/56.0.2924.87 Electron/1.6.11 Safari/537.36",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Desktop App",
    +		ExpectedBrowserVersion: "3.7.1",
    +	},
    +	{
    +		Name:                   "Franz 4.0.4",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Franz/4.0.4 Chrome/52.0.2743.82 Electron/1.3.1 Safari/537.36",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Desktop App",
    +		ExpectedBrowserVersion: "4.0.4",
    +	},
    +	{
    +		Name:                   "Edge 14",
    +		UserAgent:              "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows 10",
    +		ExpectedBrowserName:    "Edge",
    +		ExpectedBrowserVersion: "14.14393",
    +	},
    +	{
    +		Name:                   "Internet Explorer 9",
    +		UserAgent:              "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 7.1; Trident/5.0",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows",
    +		ExpectedBrowserName:    "Internet Explorer",
    +		ExpectedBrowserVersion: "9.0",
    +	},
    +	{
    +		Name:                   "Internet Explorer 11",
    +		UserAgent:              "Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows 10",
    +		ExpectedBrowserName:    "Internet Explorer",
    +		ExpectedBrowserVersion: "11.0",
    +	},
    +	{
    +		Name:                   "Internet Explorer 11 2",
    +		UserAgent:              "Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Zoom 3.6.0; rv:11.0) like Gecko",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows 10",
    +		ExpectedBrowserName:    "Internet Explorer",
    +		ExpectedBrowserVersion: "11.0",
    +	},
    +	{
    +		Name:                   "Internet Explorer 11 (Compatibility Mode) 1",
    +		UserAgent:              "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; .NET CLR 1.1.4322; InfoPath.3; Zoom 3.6.0)",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows 10",
    +		ExpectedBrowserName:    "Internet Explorer",
    +		ExpectedBrowserVersion: "7.0",
    +	},
    +	{
    +		Name:                   "Internet Explorer 11 (Compatibility Mode) 2",
    +		UserAgent:              "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 10.0; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Zoom 3.6.0)",
    +		ExpectedPlatformName:   "Windows",
    +		ExpectedOSName:         "Windows 10",
    +		ExpectedBrowserName:    "Internet Explorer",
    +		ExpectedBrowserVersion: "7.0",
    +	},
    +	{
    +		Name:                   "Safari 9",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Safari/604.1.38",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Safari",
    +		ExpectedBrowserVersion: "11.0",
    +	},
    +	{
    +		Name:                   "Safari 8",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/600.7.12 (KHTML, like Gecko) Version/8.0.7 Safari/600.7.12",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Safari",
    +		ExpectedBrowserVersion: "8.0.7",
    +	},
    +	{
    +		Name:                   "Safari Mobile",
    +		UserAgent:              "Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13B137 Safari/601.1",
    +		ExpectedPlatformName:   "iPhone",
    +		ExpectedOSName:         "iOS",
    +		ExpectedBrowserName:    "Safari",
    +		ExpectedBrowserVersion: "9.0",
    +	},
    +	{
    +		Name:                   "Mobile App",
    +		UserAgent:              "Mattermost Mobile/2.7.0+482 (Android; 13; sdk_gphone64_arm64)",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Mobile App",
    +		ExpectedBrowserVersion: "2.7.0+482",
    +	},
    +	{
    +		Name:                   "Mobile App (long version, truncated)",
    +		UserAgent:              "Mattermost Mobile/233.234441.341234223421341234529099823109834440981234+abcdef3214eafeabc3242331129857301afesfffff1930a84e4bd2348fe129ac1309bd929dca3419af934bfe3089fcd (Android; 13; sdk_gphone64_arm64)",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Mobile App",
    +		ExpectedBrowserVersion: "233.234441.341234223421341234529099823109834440981234+abcdef3214eafeabc3242331129857301afesfffff1930a84e4bd2348fe129ac1309bd929d",
    +	},
    +	{
    +		Name:                   "Firefox (Mac)",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:132.0) Gecko/20100101 Firefox/132.0",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Firefox",
    +		ExpectedBrowserVersion: "132.0",
    +	},
    +	{
    +		Name:                   "Desktop App (Mac)",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.127 Electron/31.2.1 Safari/537.36 Mattermost/5.9.0",
    +		ExpectedPlatformName:   "Macintosh",
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Desktop App",
    +		ExpectedBrowserVersion: "5.9.0",
    +	},
    +	{
    +		Name:                   "Mobile App (Android, Samsung Galaxy Fold Z)",
    +		UserAgent:              "Mattermost Mobile/2.20.0+6000556 (samsung/q4qcsx/q4q:14/UP1A.231005.007/F936WVLU4FXE3:user/release-keys; 14; SM-F936W)",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Mobile App",
    +		ExpectedBrowserVersion: "2.20.0+6000556",
    +	},
    +	{
    +		Name:                   "Chrome (Android)",
    +		UserAgent:              "Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Mobile Safari/537.36",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Chrome",
    +		ExpectedBrowserVersion: "129.0",
    +	},
    +	{
    +		Name:                   "iOS App (iPhone 13)",
    +		UserAgent:              "Mattermost Mobile/2.20.0+556 (iOS; 17.5.1; iPhone 13)",
    +		ExpectedPlatformName:   "iPhone",
    +		ExpectedOSName:         "iOS",
    +		ExpectedBrowserName:    "Mobile App",
    +		ExpectedBrowserVersion: "2.20.0+556",
    +	},
    +	{
    +		Name:                   "Safari (iPhone 13)",
    +		UserAgent:              "Mozilla/5.0 (iPhone; CPU iPhone OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Mobile/15E148 Safari/604.1",
    +		ExpectedPlatformName:   "iPhone",
    +		ExpectedOSName:         "iOS",
    +		ExpectedBrowserName:    "Safari",
    +		ExpectedBrowserVersion: "17.5",
    +	},
    +	{
    +		Name:                   "iOS App (iPad 11 Pro)",
    +		UserAgent:              "Mattermost Mobile/2.21.0+567 (iPadOS; 17.6.1; iPad Pro (11-inch) (1st generation))",
    +		ExpectedPlatformName:   "iPad",
    +		ExpectedOSName:         "iOS",
    +		ExpectedBrowserName:    "Mobile App",
    +		ExpectedBrowserVersion: "2.21.0+567",
    +	},
    +	{
    +		Name:                   "Safari (iPad 11 Pro, default)",
    +		UserAgent:              "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.6 Safari/605.1.15",
    +		ExpectedPlatformName:   "Macintosh", // iPad pretends to be a desktop Mac by default
    +		ExpectedOSName:         "Mac OS",
    +		ExpectedBrowserName:    "Safari",
    +		ExpectedBrowserVersion: "17.6",
    +	},
    +	{
    +		Name:                   "Safari (iPad 11 Pro, requesting mobile site)",
    +		UserAgent:              "Mozilla/5.0 (iPad; CPU OS 17_6_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.6 Mobile/15E148 Safari/604.1",
    +		ExpectedPlatformName:   "iPad",
    +		ExpectedOSName:         "iOS",
    +		ExpectedBrowserName:    "Safari",
    +		ExpectedBrowserVersion: "17.6",
    +	},
    +	// MM-67274: User agents with empty version strings should not panic
    +	{
    +		Name:                   "Mobile App (no version)",
    +		UserAgent:              "Mattermost Mobile/",
    +		ExpectedPlatformName:   "Linux",
    +		ExpectedOSName:         "Android",
    +		ExpectedBrowserName:    "Mobile App",
    +		ExpectedBrowserVersion: "0.0",
    +	},
    +	{
    +		Name:                   "Desktop App (no version)",
    +		UserAgent:              "Mattermost/",
    +		ExpectedPlatformName:   "Unknown",
    +		ExpectedOSName:         "",
    +		ExpectedBrowserName:    "Desktop App",
    +		ExpectedBrowserVersion: "0.0",
    +	},
    +	{
    +		Name:                   "mmctl (no version)",
    +		UserAgent:              "mmctl/",
    +		ExpectedPlatformName:   "Unknown",
    +		ExpectedOSName:         "",
    +		ExpectedBrowserName:    "mmctl",
    +		ExpectedBrowserVersion: "0.0",
    +	},
    +	{
    +		Name:                   "Franz (no version)",
    +		UserAgent:              "Franz/",
    +		ExpectedPlatformName:   "Unknown",
    +		ExpectedOSName:         "",
    +		ExpectedBrowserName:    "Unknown",
    +		ExpectedBrowserVersion: "0.0",
    +	},
     }
     
     func TestGetPlatformName(t *testing.T) {
     	mainHelper.Parallel(t)
    -	expected := []string{
    -		"Windows",
    -		"Macintosh",
    -		"Linux",
    -		"Linux",
    -		"Linux",
    -		"Macintosh",
    -		"Macintosh",
    -		"Windows",
    -		"Windows",
    -		"Windows",
    -		"Windows",
    -		"Windows",
    -		"Windows",
    -		"Macintosh",
    -		"Macintosh",
    -		"iPhone",
    -		"Linux",
    -		"Linux",
    -		"Macintosh",
    -		"Macintosh",
    -		"Linux",
    -		"Linux",
    -		"iPhone",
    -		"iPhone",
    -		"iPad",
    -		"Macintosh", // By default, the iPad pretends to be a desktop Mac when opening web pages
    -		"iPad",
    -	}
    -
    -	for i, userAgent := range testUserAgents {
    -		t.Run(fmt.Sprintf("GetPlatformName_%v", i), func(t *testing.T) {
    -			ua := uasurfer.Parse(userAgent.UserAgent)
    -
    -			actual := getPlatformName(ua, userAgent.UserAgent)
    -			assert.Equal(t, expected[i], actual)
    +	for _, tc := range testUserAgents {
    +		t.Run(tc.Name, func(t *testing.T) {
    +			ua := uasurfer.Parse(tc.UserAgent)
    +			actual := getPlatformName(ua, tc.UserAgent)
    +			assert.Equal(t, tc.ExpectedPlatformName, actual)
     		})
     	}
     }
     
     func TestGetOSName(t *testing.T) {
     	mainHelper.Parallel(t)
    -	expected := []string{
    -		"Windows 7",
    -		"Mac OS",
    -		"Android",
    -		"Android",
    -		"Linux",
    -		"Mac OS",
    -		"Mac OS",
    -		"Windows 10",
    -		"Windows",
    -		"Windows 10",
    -		"Windows 10",
    -		"Windows 10",
    -		"Windows 10",
    -		"Mac OS",
    -		"Mac OS",
    -		"iOS",
    -		"Android",
    -		"Android",
    -		"Mac OS",
    -		"Mac OS",
    -		"Android",
    -		"Android",
    -		"iOS",
    -		"iOS",
    -		"iOS",
    -		"Mac OS", // By default, the iPad pretends to be a desktop Mac when opening web pages
    -		"iOS",
    -	}
    -
    -	for i, userAgent := range testUserAgents {
    -		t.Run(fmt.Sprintf("GetOSName_%v", i), func(t *testing.T) {
    -			ua := uasurfer.Parse(userAgent.UserAgent)
    -
    -			actual := getOSName(ua, userAgent.UserAgent)
    -			assert.Equal(t, expected[i], actual)
    +	for _, tc := range testUserAgents {
    +		t.Run(tc.Name, func(t *testing.T) {
    +			ua := uasurfer.Parse(tc.UserAgent)
    +			actual := getOSName(ua, tc.UserAgent)
    +			assert.Equal(t, tc.ExpectedOSName, actual)
     		})
     	}
     }
     
     func TestGetBrowserName(t *testing.T) {
     	mainHelper.Parallel(t)
    -	expected := []string{
    -		"Firefox",
    -		"Chrome",
    -		"Chrome",
    -		"Chrome",
    -		"mmctl",
    -		"Desktop App",
    -		"Desktop App",
    -		"Edge",
    -		"Internet Explorer",
    -		"Internet Explorer",
    -		"Internet Explorer",
    -		"Internet Explorer",
    -		"Internet Explorer",
    -		"Safari",
    -		"Safari",
    -		"Safari",
    -		"Mobile App",
    -		"Mobile App",
    -		"Firefox",
    -		"Desktop App",
    -		"Mobile App",
    -		"Chrome",
    -		"Mobile App",
    -		"Safari",
    -		"Mobile App",
    -		"Safari",
    -		"Safari",
    -	}
    -
    -	for i, userAgent := range testUserAgents {
    -		t.Run(fmt.Sprintf("GetBrowserName_%v", i), func(t *testing.T) {
    -			ua := uasurfer.Parse(userAgent.UserAgent)
    -
    -			actual := getBrowserName(ua, userAgent.UserAgent)
    -			assert.Equal(t, expected[i], actual)
    +	for _, tc := range testUserAgents {
    +		t.Run(tc.Name, func(t *testing.T) {
    +			ua := uasurfer.Parse(tc.UserAgent)
    +			actual := getBrowserName(ua, tc.UserAgent)
    +			assert.Equal(t, tc.ExpectedBrowserName, actual)
     		})
     	}
     }
     
     func TestGetBrowserVersion(t *testing.T) {
     	mainHelper.Parallel(t)
    -	expected := []string{
    -		"40.1",
    -		"60.0.3112", // Doesn't report the fourth part of the version
    -		"60.0.3112", // Doesn't report the fourth part of the version
    -		"61.0.3163",
    -		"5.20.0",
    -		"3.7.1",
    -		"4.0.4",
    -		"14.14393",
    -		"9.0",
    -		"11.0",
    -		"11.0",
    -		"7.0",
    -		"7.0",
    -		"11.0",
    -		"8.0.7",
    -		"9.0",
    -		"2.7.0+482",
    -		"233.234441.341234223421341234529099823109834440981234+abcdef3214eafeabc3242331129857301afesfffff1930a84e4bd2348fe129ac1309bd929d", // cut off at len 128
    -		"132.0",
    -		"5.9.0",
    -		"2.20.0+6000556",
    -		"129.0",
    -		"2.20.0+556",
    -		"17.5",
    -		"2.21.0+567",
    -		"17.6",
    -		"17.6",
    -	}
    -
    -	for i, userAgent := range testUserAgents {
    -		t.Run(fmt.Sprintf("GetBrowserVersion_%v", i), func(t *testing.T) {
    -			ua := uasurfer.Parse(userAgent.UserAgent)
    -
    -			actual := getBrowserVersion(ua, userAgent.UserAgent)
    -			assert.Equal(t, expected[i], actual)
    +	for _, tc := range testUserAgents {
    +		t.Run(tc.Name, func(t *testing.T) {
    +			ua := uasurfer.Parse(tc.UserAgent)
    +			actual := getBrowserVersion(ua, tc.UserAgent)
    +			assert.Equal(t, tc.ExpectedBrowserVersion, actual)
     		})
     	}
     }
    

Vulnerability mechanics

Generated by null/stub on May 9, 2026. Inputs: CWE entries + fix-commit diffs from this CVE's patches. Citations validated against bundle.

References

4

News mentions

0

No linked articles in our index yet.