Missing TLS certificate verification in Faye
Description
Faye before version 1.4.0, there is a lack of certification validation in TLS handshakes. Faye uses em-http-request and faye-websocket in the Ruby version of its client. Those libraries both use the EM::Connection#start_tls method in EventMachine to implement the TLS handshake whenever a wss: URL is used for the connection. This method does not implement certificate verification by default, meaning that it does not check that the server presents a valid and trusted TLS certificate for the expected hostname. That means that any https: or wss: connection made using these libraries is vulnerable to a man-in-the-middle attack, since it does not confirm the identity of the server it is connected to. The first request a Faye client makes is always sent via normal HTTP, but later messages may be sent via WebSocket. Therefore it is vulnerable to the same problem that these underlying libraries are, and we needed both libraries to support TLS verification before Faye could claim to do the same. Your client would still be insecure if its initial HTTPS request was verified, but later WebSocket connections were not. This is fixed in Faye v1.4.0, which enables verification by default. For further background information on this issue, please see the referenced GitHub Advisory.
AI Insight
LLM-synthesized narrative grounded in this CVE's description and references.
Affected packages
Versions sourced from the GitHub Security Advisory.
| Package | Affected versions | Patched versions |
|---|---|---|
fayeRubyGems | < 1.4.0 | 1.4.0 |
Affected products
2Patches
Vulnerability mechanics
References
15- github.com/advisories/GHSA-3q49-h8f9-9fr9ghsaADVISORY
- nvd.nist.gov/vuln/detail/CVE-2020-15134ghsaADVISORY
- securitylab.github.com/advisories/GHSL-2020-094-igrigorik-em-http-requestghsaADVISORY
- blog.jcoglan.com/2020/07/31/missing-tls-verification-in-fayeghsaWEB
- blog.jcoglan.com/2020/07/31/missing-tls-verification-in-faye/mitrex_refsource_MISC
- github.com/eventmachine/eventmachine/issues/275ghsaWEB
- github.com/eventmachine/eventmachine/issues/814ghsaWEB
- github.com/eventmachine/eventmachine/pull/378ghsaWEB
- github.com/faye/faye-websocket-ruby/pull/129ghsaWEB
- github.com/faye/faye/issues/524ghsaWEB
- github.com/faye/faye/security/advisories/GHSA-3q49-h8f9-9fr9ghsax_refsource_CONFIRMWEB
- github.com/igrigorik/em-http-request/pull/340ghsaWEB
- github.com/rubysec/ruby-advisory-db/blob/master/gems/faye/CVE-2020-15134.ymlghsaWEB
- www.rubydoc.info/github/eventmachine/eventmachine/EventMachine/Connection:ssl_verify_peerghsaWEB
- www.rubydoc.info/github/eventmachine/eventmachine/EventMachine/Connection:start_tlsghsaWEB
News mentions
0No linked articles in our index yet.